Changeset 8c77c15 in subsurface


Ignore:
Timestamp:
Dec 19, 2017, 5:13:23 AM (5 weeks ago)
Author:
Dirk Hohndel <dirk@…>
Branches:
master
Children:
b7dcbb5
Parents:
8633577
git-author:
Jan Mulder <jlmulder@…> (12/19/17 04:13:06)
git-committer:
Dirk Hohndel <dirk@…> (12/19/17 05:13:23)
Message:

git storage: invalidate cache on merge dive site

In hindsight a very simple bug to fix, but it requires some
knowledge on the inner workings of our git storage. The changes
on merge of dive sites were simply not saved (completely) because
the git storage code has a cache that we need to invalidate
selectively (ie. for the dive we just gave a new dive site uuid)
to get things finally embedded in the overall commit.

The main reason this bug went unnoticed for more than 2 years is
that most people use the XML/SSRF format (where this problem is
non exsistent), and dive site merging is probably not a very
much used feature either.

Fixes: #939

Signed-off-by: Jan Mulder <jlmulder@…>

File:
1 edited

Legend:

Unmodified
Added
Removed
  • core/divesite.c

    r90674cf r8c77c15  
    337337                                continue;
    338338                        d->dive_site_uuid = ref;
     339                        invalidate_dive_cache(d);
    339340                }
    340341        }
Note: See TracChangeset for help on using the changeset viewer.